Software engineering

How to answer: “How do you handle criticism of your code?

What they’re actually asking

Ego in code review is one of the most expensive traits an engineer can bring to a team, and everyone has worked with someone who fought every comment. They're checking whether feedback makes your code better or your mood worse.

How to structure your answer

Say plainly that the code isn't you, then prove you mean it with one story where review feedback changed your mind. Bonus points for describing what you do when you think the reviewer is wrong: you argue with evidence in the thread, accept the outcome, and never relitigate it in standup.

Example answer

Early on a senior left 30 comments on my first big PR and I took it personally for about a day. Then I noticed every comment made the diff smaller. Now I want that review: at my last job I asked the harshest reviewer on the team to look at anything touching payments. When I disagree, I say why once, with a benchmark or a doc link, and if the team goes the other way, that decision is now mine too.

What sinks people

  • "I don't take it personally" with no story proving it
  • Painting every past reviewer as nitpicky — the interviewer knows who the problem was
  • Claiming you've never had a PR torn apart. Nobody believes it.

A sample answer is someone else’s answer.

Ghost writes yours — built on your background, in your voice, in under 3 seconds. Free to try.

Get my answer to this question →